From 00d265c51b69e672457502593fbc63d0ac953e27 Mon Sep 17 00:00:00 2001 From: Tamir Duberstein Date: Sun, 16 Jul 2023 13:55:01 -0400 Subject: [PATCH] Remove pointless DefaultLogger This avoids an atomic load on every log. --- aya-log/src/lib.rs | 19 +------------------ 1 file changed, 1 insertion(+), 18 deletions(-) diff --git a/aya-log/src/lib.rs b/aya-log/src/lib.rs index 854a63a4..dd5b734b 100644 --- a/aya-log/src/lib.rs +++ b/aya-log/src/lib.rs @@ -98,7 +98,7 @@ impl BpfLogger { /// Starts reading log records created with `aya-log-ebpf` and logs them /// with the default logger. See [log::logger]. pub fn init(bpf: &mut Bpf) -> Result { - BpfLogger::init_with_logger(bpf, DefaultLogger {}) + BpfLogger::init_with_logger(bpf, log::logger()) } /// Starts reading log records created with `aya-log-ebpf` and logs them @@ -356,23 +356,6 @@ macro_rules! impl_format_float { impl_format_float!(f32); impl_format_float!(f64); -#[derive(Copy, Clone, Debug)] -struct DefaultLogger; - -impl Log for DefaultLogger { - fn enabled(&self, metadata: &log::Metadata) -> bool { - log::logger().enabled(metadata) - } - - fn log(&self, record: &Record) { - log::logger().log(record) - } - - fn flush(&self) { - log::logger().flush() - } -} - #[derive(Error, Debug)] pub enum Error { #[error("log event array {} doesn't exist", MAP_NAME)]