From 2d16843d5ddd6ca645c0d888f2fc7c8519bad850 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alessandro=C2=A0Decina?= Date: Sun, 4 Jul 2021 01:09:05 +0000 Subject: [PATCH] xtask: clippy warnings --- xtask/src/codegen/aya.rs | 5 +---- xtask/src/codegen/helpers.rs | 4 ++-- xtask/src/codegen/mod.rs | 2 +- 3 files changed, 4 insertions(+), 7 deletions(-) diff --git a/xtask/src/codegen/aya.rs b/xtask/src/codegen/aya.rs index 69d043ef..5a3e080c 100644 --- a/xtask/src/codegen/aya.rs +++ b/xtask/src/codegen/aya.rs @@ -49,10 +49,7 @@ fn codegen_internal_btf_bindings(opts: &Options) -> Result<(), anyhow::Error> { .to_string(); // write the bindings, with the original helpers removed - write_to_file( - &generated.join("btf_internal_bindings.rs"), - &bindings.to_string(), - )?; + write_to_file(&generated.join("btf_internal_bindings.rs"), &bindings)?; Ok(()) } diff --git a/xtask/src/codegen/helpers.rs b/xtask/src/codegen/helpers.rs index efc965ca..54c502b6 100644 --- a/xtask/src/codegen/helpers.rs +++ b/xtask/src/codegen/helpers.rs @@ -60,11 +60,11 @@ pub fn expand_helpers(helpers: &[Helper<'_>]) -> TokenStream { tokens.append_all( helpers .iter() - .filter(|h| h.ident.to_string() != "bpf_trace_printk") + .filter(|h| *h.ident != "bpf_trace_printk") .map(expand_helper), ); - return tokens; + tokens } pub fn expand_helper(helper: &Helper<'_>) -> TokenStream { diff --git a/xtask/src/codegen/mod.rs b/xtask/src/codegen/mod.rs index d9d66726..c363b193 100644 --- a/xtask/src/codegen/mod.rs +++ b/xtask/src/codegen/mod.rs @@ -6,7 +6,7 @@ use std::path::PathBuf; use structopt::StructOpt; -const SUPPORTED_ARCHS: &'static [Architecture] = &[ +const SUPPORTED_ARCHS: &[Architecture] = &[ Architecture::X86_64, Architecture::ARMv7, Architecture::AArch64,