148 Commits (00b5cc5aaf98be16c45b31a4ec2b14b842842d6a)

Author	SHA1	Message	Date
Tamir Duberstein	9916092f5c	codegen: tidy up ... - Document the need for external rustfmt invocation. - Remove reexports. - Remove `write_to_file`. - Avoid allocating strings when using bindgen to write bindings.	1 week ago
Tamir Duberstein	34319cba12	ci,xtask: sort architectures	1 week ago
Tamir Duberstein	56ebe1406e	aya-tool: do not attempt to run rustfmt ... This can be done externally. Do so in CI. This is an attempt to resolve the inconsistency between CI and local rustfmt in the generated bindings. Restore running CI on generated branches; the presence of a PR is apparently not enough.	1 week ago
Tamir Duberstein	f0a9f19ddc	Bump edition to 2024 ... Change FromRawTracepointArgs::arg to return T rather than *const T which seems to have been returning a dangling pointer. Arguably this is not strictly necessary; edition 2024 seems to be focused on increased strictness around unsafe code which doesn't unlock new functionality for our users. That said, this work revealed an apparent bug (see above) that we wouldn't otherwise catch due to allow-by-default lints.	1 week ago
Tamir Duberstein	4101a5a55d	Use #[expect(...)] rather than #[allow(...)] ... This is stricter, and revealed a few unused allowances.	1 week ago
WANG Rui	9d0bdb56e6	chore(xtask): Add loongarch64 to codegen ... Signed-off-by: WANG Rui <wangrui@loongson.cn>	2 weeks ago
Tamir Duberstein	c8f14b18d4	codegen: tidy up ... Move some code out of a loop, where it appears to be nonsense.	1 month ago
Tamir Duberstein	9198335100	codegen: remove outdated workaround ... bindgen can handle these macros now.	1 month ago
Tamir Duberstein	2319770f5b	codegen: generate additional userspace constants	1 month ago
Tamir Duberstein	ee7861a6ed	codegen: avoid lossy string conversion ... This can't possibly work right if lossy conversion is required.	1 month ago
Dave Tucker	b16ca6f570	chore(codegen): Add nlmsgerr_attrs ... This is required for nicer netlink error messages Signed-off-by: Dave Tucker <dave@dtucker.co.uk>	1 month ago
Dave Tucker	d92284e4f8	chore(codegen): Fix duplicate BPF_F_LINK ... Per the comment added in the code, there are 2 definitions of BPF_F_LINK in the kernel headers. Once is in an anonymous enum which bindgen will constify, and once is via a #define macro. The values are identical. The fix is to exclude BPF_F_LINK from the list of variables in bindgen removing one of the duplicate definitions. Signed-off-by: Dave Tucker <dave@dtucker.co.uk>	1 month ago
Dave Tucker	74fad66599	chore(xtask): Add bindings for bpf_task_fd_type ... Signed-off-by: Dave Tucker <dave@dtucker.co.uk>	1 month ago
Ishan Jain	91fb73092e	chore(xtask): Add mips to codegen ... This will generate bindings for mips the next time that the codegen job is run. Signed-off-by: Ishan Jain <contact@ishanjain.me> Co-authored-by: Dave Tucker <dave@dtucker.co.uk>	1 month ago
Tamir Duberstein	0429ed2fa2	Appease clippy ... ``` error: manual implementation of `ok` --> aya/src/util.rs:261:28 | 261 | let addr = match u64::from_str_radix(addr, 16) { | ____________________________^ 262 | | Ok(addr) => Some(addr), 263 | | Err(ParseIntError { .. }) => None, 264 | | }?; | |_________________^ help: replace with: `u64::from_str_radix(addr, 16).ok()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_ok_err error: struct pattern is not needed for a unit variant --> aya-obj/src/obj.rs:1705:44 | 1705 | section: ProgramSection::KProbe { .. }, | ^^^^^^^ help: remove the struct pattern | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_struct_pattern note: the lint level is defined here --> aya-obj/src/lib.rs:68:9 | 68 | #![deny(clippy::all, missing_docs)] | ^^^^^^^^^^^ = note: `#[deny(clippy::unneeded_struct_pattern)]` implied by `#[deny(clippy::all)]` error: struct pattern is not needed for a unit variant --> aya-obj/src/obj.rs:1769:44 | 1769 | section: ProgramSection::KProbe { .. }, | ^^^^^^^ help: remove the struct pattern | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_struct_pattern error: struct pattern is not needed for a unit variant --> aya-obj/src/obj.rs:1787:44 | 1787 | section: ProgramSection::KProbe { .. }, | ^^^^^^^ help: remove the struct pattern | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_struct_pattern error: struct pattern is not needed for a unit variant --> aya-obj/src/obj.rs:1919:48 | 1919 | section: ProgramSection::KProbe { .. }, | ^^^^^^^ help: remove the struct pattern | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_struct_pattern error: struct pattern is not needed for a unit variant --> aya-obj/src/obj.rs:2041:52 | 2041 | section: ProgramSection::TracePoint { .. }, | ^^^^^^^ help: remove the struct pattern | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_struct_pattern error: struct pattern is not needed for a unit variant --> aya-obj/src/obj.rs:2058:52 | 2058 | section: ProgramSection::TracePoint { .. }, | ^^^^^^^ help: remove the struct pattern | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_struct_pattern error: struct pattern is not needed for a unit variant --> aya-obj/src/obj.rs:2081:54 | 2081 | section: ProgramSection::SocketFilter { .. }, | ^^^^^^^ help: remove the struct pattern | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_struct_pattern error: struct pattern is not needed for a unit variant --> aya-obj/src/obj.rs:2151:55 | 2151 | section: ProgramSection::RawTracePoint { .. }, | ^^^^^^^ help: remove the struct pattern | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_struct_pattern error: struct pattern is not needed for a unit variant --> aya-obj/src/obj.rs:2168:55 | 2168 | section: ProgramSection::RawTracePoint { .. }, | ^^^^^^^ help: remove the struct pattern | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_struct_pattern error: struct pattern is not needed for a unit variant --> aya-obj/src/obj.rs:2243:55 | 2243 | section: ProgramSection::BtfTracePoint { .. }, | ^^^^^^^ help: remove the struct pattern | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_struct_pattern error: struct pattern is not needed for a unit variant --> aya-obj/src/obj.rs:2266:59 | 2266 | section: ProgramSection::SkSkbStreamParser { .. }, | ^^^^^^^ help: remove the struct pattern | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_struct_pattern error: struct pattern is not needed for a unit variant --> aya-obj/src/obj.rs:2289:59 | 2289 | section: ProgramSection::SkSkbStreamParser { .. }, | ^^^^^^^ help: remove the struct pattern | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_struct_pattern error: struct pattern is not needed for a unit variant --> aya-obj/src/obj.rs:2410:58 | 2410 | section: ProgramSection::CgroupSkbIngress { .. }, | ^^^^^^^ help: remove the struct pattern | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_struct_pattern error: struct pattern is not needed for a unit variant --> aya-obj/src/obj.rs:2433:58 | 2433 | section: ProgramSection::CgroupSkbIngress { .. }, | ^^^^^^^ help: remove the struct pattern | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_struct_pattern error: struct pattern is not needed for a unit variant --> aya-obj/src/obj.rs:2456:51 | 2456 | section: ProgramSection::CgroupSkb { .. }, | ^^^^^^^ help: remove the struct pattern | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_struct_pattern error: struct pattern is not needed for a unit variant --> aya-obj/src/obj.rs:2479:51 | 2479 | section: ProgramSection::CgroupSkb { .. }, | ^^^^^^^ help: remove the struct pattern | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_struct_pattern error: manual implementation of `ok` --> aya-log-common/src/lib.rs:168:36 | 168 | let wire_len: LogValueLength = match value.len().try_into() { | ____________________________________^ 169 | | Ok(wire_len) => Some(wire_len), 170 | | Err(TryFromIntError { .. }) => None, 171 | | }?; | |_____^ help: replace with: `value.len().try_into().ok()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_ok_err error: manual implementation of `err` --> init/src/main.rs:141:30 | 141 | .filter_map(|result| match result { | ______________________________^ 142 | | Ok(()) => None, 143 | | Err(err) => Some(err), 144 | | }) | |_________^ help: replace with: `result.err()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_ok_err error: manual implementation of `err` --> xtask/src/public_api.rs:80:30 | 80 | .filter_map(|result| match result { | ______________________________^ 81 | | Ok(()) => None, 82 | | Err(err) => Some(err), 83 | | }) | |_________^ help: replace with: `result.err()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_ok_err ```	1 month ago
Tamir Duberstein	d1457acc6d	ci: cache downloads ... We're seeing 429 from Github trying to download gen_init_cpio, so cache it using actions cache. Since I'm here add this for kernel images as well to save time waiting on slow Debian servers.	3 months ago
Tamir Duberstein	cc2da4a2a4	ci: download gen_init_cpio with authentication ... The raw endpoint[0] now[1] seems to return HTTP 429 on the first request and unauthenticated API limits are exceeded after one request (so one of ubuntu/macos builders fails). Hopefully this works with authentication. Link: https://raw.githubusercontent.com/torvalds/linux/refs/heads/master/usr/gen_init_cpio.c [0] Link: https://github.com/orgs/community/discussions/146957 [1]	3 months ago
Tamir Duberstein	fd00b39f09	Enable unwinding in userspace ... Unwinding gives us more information, so we shouldn't disable it globally. It is already disabled for BPF targets via the target configs in rustc itself. This complicates the clippy invocation somewhat, so put it in a shell script for developer as well as CI use.	3 months ago
Tamir Duberstein	5ab67dce08	Use TargetKind enum and Target::is_proc_macro ... These are added in cargo_metadata 0.19.0.	4 months ago
Tamir Duberstein	e3bfeb9dd6	Allow QEMU to fall back	4 months ago
Tamir Duberstein	f9b34fe76f	qemu: remove bios argument ... I did this for arm64 because we'd get a black screen without it but I have now confirmed that console=ttyAMA0 solves that problem. I don't remember why I did it for x86.	5 months ago
Tyrone Wu	366c599c20	codegen: cgroup_iter_order NFPROTO* nf_inet_hooks ... Adds the following to codegen: - `bpf_cgroup_iter_order`: used in `bpf_link_info.iter.group.order` - `NFPROTO_*`: used in `bpf_link_info.netfilter.pf` - `nf_inet_hooks`: used in `bpf_link_info.netfilter.hooknum` Include `linux/netfilter.h` in `linux_wrapper.h` for `NFPROTO_*` and `nf_inet_hooks` to generate.	5 months ago
tyrone-wu	ea1130449b	codegen: add `bpf_perf_event_type` enum bindings ... Adds the `bpf_perf_event_type` enum to FFI bindings, which is being used in the `perf_event.type` field in `bpf_link_info`.	6 months ago
astoycos	a52ad4ba2a	codegen: add `tcx_action_base` enum to bindings ... Signed-off-by: astoycos <astoycos@gmail.com>	7 months ago
tyrone-wu	86e279ef0a	codegen: add bpf_stats_type ... Added `bpf_stats_type` enum to codegen bindings. Refs: #959	8 months ago
Dave Tucker	b20b1f1b0a	chore(xtask): Create bindings dir ... If the bindings directory doesn't exist then create it. Signed-off-by: Dave Tucker <dave@dtucker.co.uk>	9 months ago
Billy McFall	62efed1853	chore(xtask): Add s390x and powerpc64 to codegen ... This commit adds the s390x and powerpc architectures to codegen. This will enable an upcoming PR to add support for aya to support theses architectures in both aya and aya-ebpf. Co-authored-by: Dave Tucker <dave@dtucker.co.uk> Signed-off-by: Billy McFall <22157057+Billy99@users.noreply.github.com>	9 months ago
tyrone-wu	b23973dd9c	xtask: corrected bpf to ebpf for path to aya-ebpf-bindings in codegen ... Currently, when running `cargo +nightly xtask codegen` locally and in the codegen GHA workflow, an error occurs with only "Error: bindgen failed" displayed. This was due to a path using "bpf/..." instead of "ebpf/...". It is now corrected to "ebpf", and bindgen fails should now display a more direct message on why it failed. Fixes: #914	12 months ago
Dave Tucker	41c61560ea	chore(aya-ebpf): Rename bpf -> ebpf ... Signed-off-by: Dave Tucker <dave@dtucker.co.uk>	1 year ago
Dave Tucker	70ac91dc1e	chore(aya-ebpf-bindings): Rename bpf -> ebpf ... Signed-off-by: Dave Tucker <dave@dtucker.co.uk>	1 year ago
Dave Tucker	21f570a19c	chore(aya-ebpf-cty): Rename bpf -> ebpf ... Signed-off-by: Dave Tucker <dave@dtucker.co.uk>	1 year ago
Dave Tucker	0c58bb66b6	integration-test: Fix build.rs output ... The cargo::warning seems to ignore output after a newline. Iterate over the entire rendered message and print it line-by-line. Signed-off-by: Dave Tucker <dave@dtucker.co.uk>	1 year ago
Tamir Duberstein	5041aa41de	xtask: allow public-api regen on aarch64-apple-darwin ... ``` CARGO_CFG_BPF_TARGET_ARCH=x86_64 cargo +nightly xtask public-api --bless --target x86_64-unknown-linux-gnu ```	1 year ago
Tamir Duberstein	7a4c6153a0	xtask: terminate QEMU on "RCU grace-period kthread stack dump" ... See https://github.com/aya-rs/bpf-linker/actions/runs/7067897954/job/19241830198	1 year ago
Tamir Duberstein	42cc175aeb	xtask: attempt to open /dev/kvm ... We're seeing test failures where KVM is present but we aren't able to use it. See https://github.com/actions/runner-images/issues/7670#issuecomment-1760184162.	1 year ago
Tamir Duberstein	5392f9821d	xtask: terminate QEMU on "BUG: soft lockup" ... See https://github.com/aya-rs/aya/actions/runs/6329828507/job/17190931752. Unlike on kernel panic this message prints periodically so it is permitted to print twice before QEMU is killed.	1 year ago
Tamir Duberstein	d16e607fd4	rustfmt: group_imports = "StdExternalCrate" ... High time we stop debating this; let the robots do the work.	1 year ago
Tamir Duberstein	fe13b2eb41	xtask: remove useless copy ... /tmp/initrd.img is unused.	1 year ago
Tamir Duberstein	cbe9cd9133	xtask: appease new clippy warning ... ``` warning: unnecessary hashes around raw string literal --> xtask/src/docs.rs:70:17 | 70 | indoc! {r#" | _________________^ 71 | | User-Agent:* 72 | | Disallow: / 73 | | "#}, | |______^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_raw_string_hashes = note: `#[warn(clippy::needless_raw_string_hashes)]` on by default help: remove all the hashes around the literal | 70 ~ indoc! {r" 71 | User-Agent:* 72 | Disallow: / 73 ~ "}, | ``` This false negative was fixed in https://github.com/rust-lang/rust-clippy/pull/11518 (the title incorrectly says false positive).	1 year ago
Tamir Duberstein	782eb85d4a	xtask: extract `Errors` type ... This produces better errors in `cargo xtask public-api` because before this change we'd print errors as display, which didn't show context. Before: ``` Error: public API errors: aya failed to check public API: public_api::Builder::build aya-obj failed to check public API: public_api::Builder::build aya-log failed to check public API: public_api::Builder::build aya-log-common failed to check public API: public_api::Builder::build aya-log-parser failed to check public API: public_api::Builder::build aya-tool failed to check public API: public_api::Builder::build aya-bpf failed to check public API: public_api::Builder::build aya-bpf-bindings failed to check public API: public_api::Builder::build aya-bpf-cty failed to check public API: public_api::Builder::build aya-bpf-macros failed to check public API: public_api::Builder::build aya-log-ebpf-macros failed to check public API: public_api::Builder::build ``` After: ``` Error: aya failed to check public API Caused by: 0: public_api::Builder::build 1: unknown variant `type_alias`, expected one of `module`, `extern_crate`, `import`, `struct`, `struct_field`, `union`, `enum`, `variant`, `function`, `typedef`, `opaque_ty`, `constant`, `trait`, `trait_alias`, `impl`, `static`, `foreign_type`, `macro`, `proc_attribute`, `proc_derive`, `assoc_const`, `assoc_type`, `primitive`, `keyword` at line 1 column 3082463 aya-obj failed to check public API Caused by: 0: public_api::Builder::build 1: unknown variant `type_alias`, expected one of `module`, `extern_crate`, `import`, `union`, `struct`, `struct_field`, `enum`, `variant`, `function`, `trait`, `trait_alias`, `impl`, `typedef`, `opaque_ty`, `constant`, `static`, `foreign_type`, `macro`, `proc_macro`, `primitive`, `assoc_const`, `assoc_type` at line 1 column 129355 aya-log failed to check public API Caused by: 0: public_api::Builder::build 1: unknown variant `type_alias`, expected one of `module`, `extern_crate`, `import`, `struct`, `struct_field`, `union`, `enum`, `variant`, `function`, `typedef`, `opaque_ty`, `constant`, `trait`, `trait_alias`, `impl`, `static`, `foreign_type`, `macro`, `proc_attribute`, `proc_derive`, `assoc_const`, `assoc_type`, `primitive`, `keyword` at line 1 column 311910 aya-log-common failed to check public API Caused by: 0: public_api::Builder::build 1: unknown variant `type_alias`, expected one of `module`, `extern_crate`, `import`, `union`, `struct`, `struct_field`, `enum`, `variant`, `function`, `trait`, `trait_alias`, `impl`, `typedef`, `opaque_ty`, `constant`, `static`, `foreign_type`, `macro`, `proc_macro`, `primitive`, `assoc_const`, `assoc_type` at line 1 column 130456 aya-log-parser failed to check public API Caused by: 0: public_api::Builder::build 1: unknown variant `type_alias`, expected one of `module`, `extern_crate`, `import`, `struct`, `struct_field`, `union`, `enum`, `variant`, `function`, `typedef`, `opaque_ty`, `constant`, `trait`, `trait_alias`, `impl`, `static`, `foreign_type`, `macro`, `proc_attribute`, `proc_derive`, `assoc_const`, `assoc_type`, `primitive`, `keyword` at line 1 column 204930 aya-tool failed to check public API Caused by: 0: public_api::Builder::build 1: unknown variant `type_alias`, expected one of `module`, `extern_crate`, `import`, `struct`, `struct_field`, `union`, `enum`, `variant`, `function`, `typedef`, `opaque_ty`, `constant`, `trait`, `trait_alias`, `impl`, `static`, `foreign_type`, `macro`, `proc_attribute`, `proc_derive`, `assoc_const`, `assoc_type`, `primitive`, `keyword` at line 1 column 234519 aya-bpf failed to check public API Caused by: 0: public_api::Builder::build 1: unknown variant `type_alias`, expected one of `module`, `extern_crate`, `import`, `struct`, `struct_field`, `union`, `enum`, `variant`, `function`, `typedef`, `opaque_ty`, `constant`, `trait`, `trait_alias`, `impl`, `static`, `foreign_type`, `macro`, `proc_attribute`, `proc_derive`, `assoc_const`, `assoc_type`, `primitive`, `keyword` at line 1 column 741697 aya-bpf-bindings failed to check public API Caused by: 0: public_api::Builder::build 1: unknown variant `type_alias`, expected one of `module`, `extern_crate`, `import`, `union`, `struct`, `struct_field`, `enum`, `variant`, `function`, `trait`, `trait_alias`, `impl`, `typedef`, `opaque_ty`, `constant`, `static`, `foreign_type`, `macro`, `proc_macro`, `primitive`, `assoc_const`, `assoc_type` at line 1 column 112445 aya-bpf-cty failed to check public API Caused by: 0: public_api::Builder::build 1: unknown variant `type_alias`, expected one of `module`, `extern_crate`, `import`, `union`, `struct`, `struct_field`, `enum`, `variant`, `function`, `trait`, `trait_alias`, `impl`, `typedef`, `opaque_ty`, `constant`, `static`, `foreign_type`, `macro`, `proc_macro`, `primitive`, `assoc_const`, `assoc_type` at line 1 column 315 aya-bpf-macros failed to check public API Caused by: 0: public_api::Builder::build 1: unknown variant `type_alias`, expected one of `module`, `extern_crate`, `import`, `struct`, `struct_field`, `union`, `enum`, `variant`, `function`, `typedef`, `opaque_ty`, `constant`, `trait`, `trait_alias`, `impl`, `static`, `foreign_type`, `macro`, `proc_attribute`, `proc_derive`, `assoc_const`, `assoc_type`, `primitive`, `keyword` at line 1 column 186226 aya-log-ebpf-macros failed to check public API Caused by: 0: public_api::Builder::build 1: unknown variant `type_alias`, expected one of `module`, `extern_crate`, `import`, `struct`, `struct_field`, `union`, `enum`, `variant`, `function`, `typedef`, `opaque_ty`, `constant`, `trait`, `trait_alias`, `impl`, `static`, `foreign_type`, `macro`, `proc_attribute`, `proc_derive`, `assoc_const`, `assoc_type`, `primitive`, `keyword` at line 1 column 158055 ```	2 years ago
Tamir Duberstein	ca2e43d318	integration-test: Remove cargo symlink workaround ... https://github.com/rust-lang/cargo/pull/12369 fixed this bug and was picked up in https://github.com/rust-lang/rust/pull/114027.	2 years ago
Tamir Duberstein	7e14214f47	xtask: add noapic to kernel parameters ... This might prevent some kernel panics.	2 years ago
Tamir Duberstein	de65ba0067	xtask: watch for kernel panic in stdout too ... Seems unclear whether kernel panics go to stdout or stderr, so do them both.	2 years ago
Tamir Duberstein	58ba66c003	xtask: watch for kernel panics on stderr ... It seems these go to stderr, not stdout. Use `Ctrl-A x` to shut QEMU down if a panic is seen.	2 years ago
Tamir Duberstein	82a77bc83d	integration-test: Implement running on VMs ... Implements running integration tests on multiple VMs with arbitrary kernel images using `cargo xtask integration-test vm ...`. This changes our coverage from 6.2 to 6.1 and 6.4.	2 years ago
Tamir Duberstein	dc9f72adf0	test,xtask: Simplify ExitStatus handling	2 years ago
Tamir Duberstein	8d7545aff8	xtask: reverse public API diff direction ... This is currently producing inverse diffs.	2 years ago
Tamir Duberstein	321bda7539	public-api: simplify and improve output	2 years ago
Dave Tucker	f833f1fc1d	xtask: Add cargo-public-api ... Adds cargo-public-api. This allows for public API changes to get caught in CI, requiring new changes to be "blessed" by using: cargo xtask public-api --bless When this file is changed for aya, Alessandro will need to review the PR. Signed-off-by: Dave Tucker <dave@dtucker.co.uk>	2 years ago
Tamir Duberstein	a6b1fb9a1e	xtask: allow arbitrary flags to cargo build	2 years ago