158 Commits (0edc13b4d4b87809b41b1a14101962a7defba65e)

Author	SHA1	Message	Date
Tuetuopay	0edc13b4d4	bpf: add a shared try_redirect_map function for XDP maps	1 year ago
Tuetuopay	579e3cee22	aya, bpf: misc fixes following review comments	1 year ago
Tuetuopay	46551de3e7	xtask: bless public-api	1 year ago
Dave Tucker	42fd82e32b	Merge pull request #790 from dave-tucker/no-map-pinned	1 year ago
Dave Tucker	938f979fe7	aya: Make MapData::pin pub ... This is to solve a use-case where a user (in this case bpfd) may want to: - MapData::from_pin to open a pinned map from bpffs - MapData::pin to pin that object into another bpffs Both operations should be easily accomplished without needing to cast a MapData into a concrete Map type - e.g aya::maps::HashMap. Signed-off-by: Dave Tucker <dave@dtucker.co.uk>	1 year ago
Dave Tucker	0f4021ec89	aya: Remove MapData::pinned ... BPF objects can be pinned multiple times, to multiple different places. Tracking whether or not a map is pinned in a bool is therefore not sufficient. We could track this in a HashSet<PathBuf>, but there is really no reason to track it at all. Signed-off-by: Dave Tucker <dave@dtucker.co.uk>	1 year ago
Andrew Stoycos	0b6ea313de	Merge pull request #782 from astoycos/prog-info ... aya: add program_info() api to `Program`	1 year ago
Tamir Duberstein	f41592663c	maps: `MapFd` and `SockMapFd` are owned ... `MapData::fd` is now a `MapFd`. This means that `MapData` now closes the file descriptor on drop. In the future we might consider making `MapFd` hold a `BorrowedFd` but this requires API design work due to overlapping borrows. Since `SockMapFd` is no longer `Copy`, attach methods to take it by reference to allow callers to use it multiple times as they are accustomed to doing. `SockMapFd` implements `try_clone`. `MapFd` and `SockMapFd` are now returned by reference to allow callers to avoid file descriptor cloning when desired. This is an API breaking change. Updates #612.	1 year ago
astoycos	6ab7475fa6	aya: add program_info() api to program ... Add a new api to the outer level `Program` structure which allows users to get the program's kernel info before casting it to an explicit program variant. Signed-off-by: astoycos <astoycos@redhat.com>	1 year ago
Tamir Duberstein	92d3056db3	Merge pull request #775 from aya-rs/perf-as-raw-fd ... async_perf_event_array: access inner through async	1 year ago
Andrew Werner	2a1bf609b2	aya/maps: rework TryFrom macros ... The old macros were repetitive and inflexible. This unifies the various macros used to generate TryFrom implementations for map implementations from the relevant map enum variants. Cleanup in anticipation of fixing #636. The API changes are just about renaming the return to Self and Self::Error; they are not real changes.	1 year ago
Tamir Duberstein	8b0c7f1204	async_perf_event_array: access inner through async ... Avoid holding onto raw file descriptors. Remove some implied bounds (BorrowMut implies Borrow).	1 year ago
Andrés Medina	6895b1e2ed	aya: Use AsFd when attaching fds to programs ... This is a breaking change but adds another level of safety to ensure the file descriptor we receive is valid. Additionally, this allows aya to internally easily duplicate this file descriptor using std library methods instead of manually calling `dup` which doesn't duplicate with the CLOSE_ON_EXEC flag that is standard pratice to avoid leaking the file descriptor when exec'ing.	1 year ago
Tamir Duberstein	782eb85d4a	xtask: extract `Errors` type ... This produces better errors in `cargo xtask public-api` because before this change we'd print errors as display, which didn't show context. Before: ``` Error: public API errors: aya failed to check public API: public_api::Builder::build aya-obj failed to check public API: public_api::Builder::build aya-log failed to check public API: public_api::Builder::build aya-log-common failed to check public API: public_api::Builder::build aya-log-parser failed to check public API: public_api::Builder::build aya-tool failed to check public API: public_api::Builder::build aya-bpf failed to check public API: public_api::Builder::build aya-bpf-bindings failed to check public API: public_api::Builder::build aya-bpf-cty failed to check public API: public_api::Builder::build aya-bpf-macros failed to check public API: public_api::Builder::build aya-log-ebpf-macros failed to check public API: public_api::Builder::build ``` After: ``` Error: aya failed to check public API Caused by: 0: public_api::Builder::build 1: unknown variant `type_alias`, expected one of `module`, `extern_crate`, `import`, `struct`, `struct_field`, `union`, `enum`, `variant`, `function`, `typedef`, `opaque_ty`, `constant`, `trait`, `trait_alias`, `impl`, `static`, `foreign_type`, `macro`, `proc_attribute`, `proc_derive`, `assoc_const`, `assoc_type`, `primitive`, `keyword` at line 1 column 3082463 aya-obj failed to check public API Caused by: 0: public_api::Builder::build 1: unknown variant `type_alias`, expected one of `module`, `extern_crate`, `import`, `union`, `struct`, `struct_field`, `enum`, `variant`, `function`, `trait`, `trait_alias`, `impl`, `typedef`, `opaque_ty`, `constant`, `static`, `foreign_type`, `macro`, `proc_macro`, `primitive`, `assoc_const`, `assoc_type` at line 1 column 129355 aya-log failed to check public API Caused by: 0: public_api::Builder::build 1: unknown variant `type_alias`, expected one of `module`, `extern_crate`, `import`, `struct`, `struct_field`, `union`, `enum`, `variant`, `function`, `typedef`, `opaque_ty`, `constant`, `trait`, `trait_alias`, `impl`, `static`, `foreign_type`, `macro`, `proc_attribute`, `proc_derive`, `assoc_const`, `assoc_type`, `primitive`, `keyword` at line 1 column 311910 aya-log-common failed to check public API Caused by: 0: public_api::Builder::build 1: unknown variant `type_alias`, expected one of `module`, `extern_crate`, `import`, `union`, `struct`, `struct_field`, `enum`, `variant`, `function`, `trait`, `trait_alias`, `impl`, `typedef`, `opaque_ty`, `constant`, `static`, `foreign_type`, `macro`, `proc_macro`, `primitive`, `assoc_const`, `assoc_type` at line 1 column 130456 aya-log-parser failed to check public API Caused by: 0: public_api::Builder::build 1: unknown variant `type_alias`, expected one of `module`, `extern_crate`, `import`, `struct`, `struct_field`, `union`, `enum`, `variant`, `function`, `typedef`, `opaque_ty`, `constant`, `trait`, `trait_alias`, `impl`, `static`, `foreign_type`, `macro`, `proc_attribute`, `proc_derive`, `assoc_const`, `assoc_type`, `primitive`, `keyword` at line 1 column 204930 aya-tool failed to check public API Caused by: 0: public_api::Builder::build 1: unknown variant `type_alias`, expected one of `module`, `extern_crate`, `import`, `struct`, `struct_field`, `union`, `enum`, `variant`, `function`, `typedef`, `opaque_ty`, `constant`, `trait`, `trait_alias`, `impl`, `static`, `foreign_type`, `macro`, `proc_attribute`, `proc_derive`, `assoc_const`, `assoc_type`, `primitive`, `keyword` at line 1 column 234519 aya-bpf failed to check public API Caused by: 0: public_api::Builder::build 1: unknown variant `type_alias`, expected one of `module`, `extern_crate`, `import`, `struct`, `struct_field`, `union`, `enum`, `variant`, `function`, `typedef`, `opaque_ty`, `constant`, `trait`, `trait_alias`, `impl`, `static`, `foreign_type`, `macro`, `proc_attribute`, `proc_derive`, `assoc_const`, `assoc_type`, `primitive`, `keyword` at line 1 column 741697 aya-bpf-bindings failed to check public API Caused by: 0: public_api::Builder::build 1: unknown variant `type_alias`, expected one of `module`, `extern_crate`, `import`, `union`, `struct`, `struct_field`, `enum`, `variant`, `function`, `trait`, `trait_alias`, `impl`, `typedef`, `opaque_ty`, `constant`, `static`, `foreign_type`, `macro`, `proc_macro`, `primitive`, `assoc_const`, `assoc_type` at line 1 column 112445 aya-bpf-cty failed to check public API Caused by: 0: public_api::Builder::build 1: unknown variant `type_alias`, expected one of `module`, `extern_crate`, `import`, `union`, `struct`, `struct_field`, `enum`, `variant`, `function`, `trait`, `trait_alias`, `impl`, `typedef`, `opaque_ty`, `constant`, `static`, `foreign_type`, `macro`, `proc_macro`, `primitive`, `assoc_const`, `assoc_type` at line 1 column 315 aya-bpf-macros failed to check public API Caused by: 0: public_api::Builder::build 1: unknown variant `type_alias`, expected one of `module`, `extern_crate`, `import`, `struct`, `struct_field`, `union`, `enum`, `variant`, `function`, `typedef`, `opaque_ty`, `constant`, `trait`, `trait_alias`, `impl`, `static`, `foreign_type`, `macro`, `proc_attribute`, `proc_derive`, `assoc_const`, `assoc_type`, `primitive`, `keyword` at line 1 column 186226 aya-log-ebpf-macros failed to check public API Caused by: 0: public_api::Builder::build 1: unknown variant `type_alias`, expected one of `module`, `extern_crate`, `import`, `struct`, `struct_field`, `union`, `enum`, `variant`, `function`, `typedef`, `opaque_ty`, `constant`, `trait`, `trait_alias`, `impl`, `static`, `foreign_type`, `macro`, `proc_attribute`, `proc_derive`, `assoc_const`, `assoc_type`, `primitive`, `keyword` at line 1 column 158055 ```	1 year ago
Tamir Duberstein	1ccfdbc175	aya: support non-UTF8 probing ... Fixes #751.	1 year ago
Tamir Duberstein	0bba9b14b0	maps,programs: avoid path UTF-8 assumptions	1 year ago
Tamir Duberstein	ff8c124770	Merge pull request #763 from aya-rs/lints ... aya: deny various allow-by-default lints	1 year ago
Tamir Duberstein	ca2e43d318	integration-test: Remove cargo symlink workaround ... https://github.com/rust-lang/cargo/pull/12369 fixed this bug and was picked up in https://github.com/rust-lang/rust/pull/114027.	1 year ago
Tamir Duberstein	abda239d63	aya: deny various allow-by-default lints ... Notably: - clippy::use_self: replaced many T with Self. - single_use_lifetimes: removed some single use lifetimes. - unreachable_pub: removed some unreachable pub items. - unused_crate_dependencies: removed unused futures,parking_lot deps. - unused_qualifications: found a potential `crate` vs `$crate` bug. - let_underscore_drop: not enabled, seems to trigger false positives. - missing_copy_implementations: not enabled, unclear if we want this. - unsafe_op_in_unsafe_fn: not enabled, unclear if we want this. - unused_results: not enabled, needs many fixes (but I think wanted).	1 year ago
Tamir Duberstein	a31544b6e7	maps: BloomFilter::insert takes &mut self ... This is consistent with all the other maps.	2 years ago
Tamir Duberstein	89bc255f1d	aya: MapData::fd is non-optional ... The primary driver of change here is that `MapData::create` is now a factory function that returns `Result<Self, _>` rather than mutating `&mut self`. The remaining changes are consequences of that change, the most notable of which is the removal of several errors which are no longer possible.	2 years ago
Tamir Duberstein	ae6526e59b	programs: `ProgramData::attach_prog_fd` is owned ... This prevents a file descriptor leak when extensions are used. This is an API breaking change. Updates #612.	2 years ago
Tamir Duberstein	8b3a93161d	xtask: bless API with new nightly	2 years ago
Tamir Duberstein	504fd1df0a	programs: `ProgramFd` is owned ... `ProgramData::fd` is now a `ProgramFd`. This means that `ProgramData` now closes the file descriptor on drop. In the future we might consider making `ProgramFd` hold a `BorrowedFd` but this requires API design work due to overlapping borrows. Since `ProgramFd` is no longer `Copy`, update methods to take it by reference to allow callers to use it multiple times as they are accustomed to doing. `ProgramFd` is now returned by reference and implements `try_clone` to allow callers to avoid file descriptor cloning when desired. This is an API breaking change. Updates #612.	2 years ago
Andrew Stoycos	bcc9743254	Merge pull request #637 from astoycos/helpers ... Add more helpful methods to `ProgramInfo`	2 years ago
Andrew Stoycos	e1a556894c	aya: add helper methods for ProgramInfo ... - Add helper methods to get useful information from the ProgramInfo object which is returned by the `loaded_programs()` API. Specifically this code mirrors the `bpftool prog` command in terms of useful fields. - Add a new API macro to each aya `Program` type to allow us to fetch its accompanying `ProgramInfo` metadata after its been loaded. - Add a new ProgramInfo constructor that builds a new instance using a raw fd. - Add a smoke test for the loaded_programs() API as well as all the relevant methods on the ProgramInfo type. Signed-off-by: Andrew Stoycos <astoycos@redhat.com>	2 years ago
Dave Tucker	db975e9778	aya: Don't store bpf_fd in MapData ... This is only used in create and therefore can be passed as a parameter. Signed-off-by: Dave Tucker <dave@dtucker.co.uk>	2 years ago
Dave Tucker	d85afe78f9	xtask: Fix aya public-api ... Changes to the bitflags crate changed some of our public api signature. Signed-off-by: Dave Tucker <dave@dtucker.co.uk>	2 years ago
Tamir Duberstein	7e14214f47	xtask: add noapic to kernel parameters ... This might prevent some kernel panics.	2 years ago
Tamir Duberstein	de65ba0067	xtask: watch for kernel panic in stdout too ... Seems unclear whether kernel panics go to stdout or stderr, so do them both.	2 years ago
Addison Crump	ed777273b1	nuclear option: no symbol resolution in the crate	2 years ago
Tamir Duberstein	58ba66c003	xtask: watch for kernel panics on stderr ... It seems these go to stderr, not stdout. Use `Ctrl-A x` to shut QEMU down if a panic is seen.	2 years ago
Tamir Duberstein	ca3f70b16a	aya-log: s/Result<usize, ()>/Option<NonZeroUsize>/ ... `Option<NonZeroUsize>` is guaranteed to have the same size as `usize`, which is not guarnateed for `Result`. This is a minor optimization, but also results in simpler code.	2 years ago
Tamir Duberstein	82a77bc83d	integration-test: Implement running on VMs ... Implements running integration tests on multiple VMs with arbitrary kernel images using `cargo xtask integration-test vm ...`. This changes our coverage from 6.2 to 6.1 and 6.4.	2 years ago
Tamir Duberstein	84d5791d4e	Merge pull request #729 from aya-rs/logs-inline-always ... log: annotate logging functions inlining	2 years ago
Dave Tucker	e38e2566e3	aya, aya-obj: Implement ENUM64 fixups ... This commit adds: - A probe to see if the ENUM64 feature is supported - Fixups for the use of signed enums, or enum64 types on systems where enum64 is not supported Signed-off-by: Dave Tucker <dave@dtucker.co.uk>	2 years ago
Tamir Duberstein	fe047d79a3	aya-log-common: Simplify ... - Remove `TagLenValue`; this type has a single method, which is now a function. - Remove generics from `TagLenValue::write` (now `write`). The tag is always `u8`, and the value is always a sequence of bytes. - Replace slicing operations which can panic with calls to `get` which explicit check bounds.	2 years ago
Tamir Duberstein	dc9f72adf0	test,xtask: Simplify ExitStatus handling	2 years ago
Tamir Duberstein	bcbb7e08fa	Cargo.toml: Remove default-features settings ... These are all set to false at the root.	2 years ago
Andrés Medina	8ebf0ac327	aya: Use OwnedFd in FdLink.	2 years ago
Dave Tucker	e9153792f1	Merge pull request #720 from dave-tucker/programsection-noname ... aya-obj: Remove name from ProgramSection	2 years ago
Addison Crump	d8709de9f2	Extract trait SymbolResolver	2 years ago
Dave Tucker	cca9b8f1a7	aya-obj: Remove name from ProgramSection ... The name here is never used as we get the program name from the symbol table instead. Signed-off-by: Dave Tucker <dave@dtucker.co.uk>	2 years ago
Dave Tucker	77e9603976	Merge pull request #711 from dave-tucker/sleepable ... Tidy up aya-bpf-macros (again)	2 years ago
Dave Tucker	677e7bda4a	aya-obj: Propagate sleepable into ProgramSection ... Signed-off-by: Dave Tucker <dave@dtucker.co.uk>	2 years ago
Tamir Duberstein	a0af7e0b2f	programs: make `loaded_programs` opaque	2 years ago
Tamir Duberstein	de8519a380	sys: extract common SyscallError ... We currently have 4 copies of this.	2 years ago
Dave Tucker	bf7fdff1ce	aya: Find programs using the symbol table ... This makes a few changes to the way that Aya reads the ELF object files. 1. To find programs in a section, we use the symbols table. This allows for cases where multiple programs could appear in the same section. 2. When parsing our ELF file we build symbols_by_section_index as an optimization as we use it for legacy maps, BTF maps and now programs. As a result of theses changes the "NAME" used in `bpf.prog_mut("NAME")` is now ALWAYS the same as the function name in the eBPF code, making the user experience more consistent. Signed-off-by: Dave Tucker <dave@dtucker.co.uk>	2 years ago
Tamir Duberstein	8961be9526	Do not escape newlines on Err(LoadError).unwrap() ... Wrap verifier logs in a newtype whose `Debug` impl emits unescaped newlines. This improves ergonomics in tests where we `Result::unwrap()` those load errors; when these fail today they emit the errors with newlines escaped, making them incredibly difficult to read.	2 years ago
Tamir Duberstein	8d7545aff8	xtask: reverse public API diff direction ... This is currently producing inverse diffs.	2 years ago