I have been down a rabbit hole of cleaning up the aya error types 😅
Most of the important changes are in `errors.rs`.
TL;DR
Current exposed types are:
- `EbpfError`
- `ProgramError`
- `MapError`
- `LinkError`
- `PerfBufferError`
- `SysError`
Honestly I'm still thinking about how we could collapse those types.
Either into a single type, or at least fewer than we expose today.
Within each of those types, I've tried to remove any invariants
that don't have any business being public (e.g if a syscall fails
with -EINVAL, there is nothing at runtime you can do about it
other than bailing).
👆 (and the spaghetti of errors depending on other errors) are
replaced by an `Other` invariant that's a Box<dyn std::error::Error>.
There are still some `pub(crate) XInternalError` types, but these
are used only to make nice error messages. This could plausibly be
replaced with anyhow/context etc.. But I've left it as-is for now.
Signed-off-by: Dave Tucker <dave@dtucker.co.uk>
Adds cargo-public-api. This allows for public API changes to get caught
in CI, requiring new changes to be "blessed" by using:
cargo xtask public-api --bless
When this file is changed for aya, Alessandro will need to review the PR.
Signed-off-by: Dave Tucker <dave@dtucker.co.uk>
Dave Tucker
GrigorenkoPV
Alessandro Decina
Tamir Duberstein
dependabot[bot]