7 Commits (73a34e1571a606124c7e89ecf71ff001508643dc)

Author	SHA1	Message	Date
Tamir Duberstein	f0a9f19ddc	Bump edition to 2024 ... Change FromRawTracepointArgs::arg to return T rather than *const T which seems to have been returning a dangling pointer. Arguably this is not strictly necessary; edition 2024 seems to be focused on increased strictness around unsafe code which doesn't unlock new functionality for our users. That said, this work revealed an apparent bug (see above) that we wouldn't otherwise catch due to allow-by-default lints.	1 week ago
Tamir Duberstein	4101a5a55d	Use #[expect(...)] rather than #[allow(...)] ... This is stricter, and revealed a few unused allowances.	1 week ago
Tamir Duberstein	0429ed2fa2	Appease clippy ... ``` error: manual implementation of `ok` --> aya/src/util.rs:261:28 | 261 | let addr = match u64::from_str_radix(addr, 16) { | ____________________________^ 262 | | Ok(addr) => Some(addr), 263 | | Err(ParseIntError { .. }) => None, 264 | | }?; | |_________________^ help: replace with: `u64::from_str_radix(addr, 16).ok()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_ok_err error: struct pattern is not needed for a unit variant --> aya-obj/src/obj.rs:1705:44 | 1705 | section: ProgramSection::KProbe { .. }, | ^^^^^^^ help: remove the struct pattern | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_struct_pattern note: the lint level is defined here --> aya-obj/src/lib.rs:68:9 | 68 | #![deny(clippy::all, missing_docs)] | ^^^^^^^^^^^ = note: `#[deny(clippy::unneeded_struct_pattern)]` implied by `#[deny(clippy::all)]` error: struct pattern is not needed for a unit variant --> aya-obj/src/obj.rs:1769:44 | 1769 | section: ProgramSection::KProbe { .. }, | ^^^^^^^ help: remove the struct pattern | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_struct_pattern error: struct pattern is not needed for a unit variant --> aya-obj/src/obj.rs:1787:44 | 1787 | section: ProgramSection::KProbe { .. }, | ^^^^^^^ help: remove the struct pattern | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_struct_pattern error: struct pattern is not needed for a unit variant --> aya-obj/src/obj.rs:1919:48 | 1919 | section: ProgramSection::KProbe { .. }, | ^^^^^^^ help: remove the struct pattern | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_struct_pattern error: struct pattern is not needed for a unit variant --> aya-obj/src/obj.rs:2041:52 | 2041 | section: ProgramSection::TracePoint { .. }, | ^^^^^^^ help: remove the struct pattern | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_struct_pattern error: struct pattern is not needed for a unit variant --> aya-obj/src/obj.rs:2058:52 | 2058 | section: ProgramSection::TracePoint { .. }, | ^^^^^^^ help: remove the struct pattern | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_struct_pattern error: struct pattern is not needed for a unit variant --> aya-obj/src/obj.rs:2081:54 | 2081 | section: ProgramSection::SocketFilter { .. }, | ^^^^^^^ help: remove the struct pattern | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_struct_pattern error: struct pattern is not needed for a unit variant --> aya-obj/src/obj.rs:2151:55 | 2151 | section: ProgramSection::RawTracePoint { .. }, | ^^^^^^^ help: remove the struct pattern | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_struct_pattern error: struct pattern is not needed for a unit variant --> aya-obj/src/obj.rs:2168:55 | 2168 | section: ProgramSection::RawTracePoint { .. }, | ^^^^^^^ help: remove the struct pattern | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_struct_pattern error: struct pattern is not needed for a unit variant --> aya-obj/src/obj.rs:2243:55 | 2243 | section: ProgramSection::BtfTracePoint { .. }, | ^^^^^^^ help: remove the struct pattern | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_struct_pattern error: struct pattern is not needed for a unit variant --> aya-obj/src/obj.rs:2266:59 | 2266 | section: ProgramSection::SkSkbStreamParser { .. }, | ^^^^^^^ help: remove the struct pattern | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_struct_pattern error: struct pattern is not needed for a unit variant --> aya-obj/src/obj.rs:2289:59 | 2289 | section: ProgramSection::SkSkbStreamParser { .. }, | ^^^^^^^ help: remove the struct pattern | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_struct_pattern error: struct pattern is not needed for a unit variant --> aya-obj/src/obj.rs:2410:58 | 2410 | section: ProgramSection::CgroupSkbIngress { .. }, | ^^^^^^^ help: remove the struct pattern | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_struct_pattern error: struct pattern is not needed for a unit variant --> aya-obj/src/obj.rs:2433:58 | 2433 | section: ProgramSection::CgroupSkbIngress { .. }, | ^^^^^^^ help: remove the struct pattern | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_struct_pattern error: struct pattern is not needed for a unit variant --> aya-obj/src/obj.rs:2456:51 | 2456 | section: ProgramSection::CgroupSkb { .. }, | ^^^^^^^ help: remove the struct pattern | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_struct_pattern error: struct pattern is not needed for a unit variant --> aya-obj/src/obj.rs:2479:51 | 2479 | section: ProgramSection::CgroupSkb { .. }, | ^^^^^^^ help: remove the struct pattern | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_struct_pattern error: manual implementation of `ok` --> aya-log-common/src/lib.rs:168:36 | 168 | let wire_len: LogValueLength = match value.len().try_into() { | ____________________________________^ 169 | | Ok(wire_len) => Some(wire_len), 170 | | Err(TryFromIntError { .. }) => None, 171 | | }?; | |_____^ help: replace with: `value.len().try_into().ok()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_ok_err error: manual implementation of `err` --> init/src/main.rs:141:30 | 141 | .filter_map(|result| match result { | ______________________________^ 142 | | Ok(()) => None, 143 | | Err(err) => Some(err), 144 | | }) | |_________^ help: replace with: `result.err()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_ok_err error: manual implementation of `err` --> xtask/src/public_api.rs:80:30 | 80 | .filter_map(|result| match result { | ______________________________^ 81 | | Ok(()) => None, 82 | | Err(err) => Some(err), 83 | | }) | |_________^ help: replace with: `result.err()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_ok_err ```	1 month ago
Dave Tucker	3aa2745972	test(init): run test with debug logs ... This provides more useful failure messages when integration tests fail Signed-off-by: Dave Tucker <dave@dtucker.co.uk>	4 months ago
Dave Tucker	b3e7ef741c	chore: Use the cargo workspace package table ... This allows for inheritance of common fields from the workspace root. The following fields have been made common: - authors - license - repository - homepage - edition Signed-off-by: Dave Tucker <dave@dtucker.co.uk>	1 year ago
Tamir Duberstein	af935f84bf	init: appease clippy ... ``` warning: in a `match` scrutinee, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a `let` --> init/src/main.rs:127:23 | 127 | match (|| { | _______________________^ 128 | | let entry = entry.context("read_dir(/bin) failed")?; 129 | | let path = entry.path(); 130 | | let status = std::process::Command::new(&path) ... | 139 | | } 140 | | })() { | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blocks_in_conditions = note: `#[warn(clippy::blocks_in_conditions)]` on by default ``` https://github.com/rust-lang/rust-clippy/pull/11853 landed in nightly.	1 year ago
Tamir Duberstein	82a77bc83d	integration-test: Implement running on VMs ... Implements running integration tests on multiple VMs with arbitrary kernel images using `cargo xtask integration-test vm ...`. This changes our coverage from 6.2 to 6.1 and 6.4.	2 years ago