56 Commits (7a3c03e178ced68f63cd1f6cfa3f8fa56459aee9)

Author	SHA1	Message	Date
Friday Ortiz	ab38afe95d	perf_event: support hardware breakpoints ... Implement `PerfEventConfig::Breakpoint`, allowing users to attach hardware breakpoints. Generate `HW_BREAKPOINT_*` and `struct bpf_perf_event_data` in support of this feature and update the type of `PerfEventContext` accordingly. Add a test exercising R, W, RW, and X breakpoints. Note that R breakpoints are unsupported on x86, and this is asserted in the test. Extend the VM integration test harness and supporting infrastructure (e.g. `download_kernel_images.sh`) to download kernel debug packages and mount `System.map` in initramfs. This is needed (at least) on the aarch 6.1 Debian kernel which was not compiled with `CONFIG_KALLSYMS_ALL=y` for some reason, and the locations of globals are not available in kallsyms. To attach breakpoints to these symbols in the test pipeline, we need to read them from System.map and apply the KASLR offset to get their real address. The `System.map` file is not provided in the kernel package by default, so we need to extract it from the corresponding debug package. The KASLR offset is computed using `gunzip` which appears in kallsyms on all Debian kernels tested. Co-authored-by: Tamir Duberstein <tamird@gmail.com>	4 weeks ago
Tamir Duberstein	0484ab5c57	xtask: use `-cpu host` iff host == guest	4 weeks ago
Tamir Duberstein	989a465f0c	xtask: avoid extracting complete archives ... Now that we're no longer shelling out to do this, we can avoid most of the work. Operate directly on the archive, unpacking only what we need.	1 month ago
Tamir Duberstein	2b8cd557aa	xtask: drop build script logging prefix ... This code doesn't run under cargo.	1 month ago
Tamir Duberstein	468b9b73db	xtask: use `-cpu host` on x86 ... We have started to see errors in CI: qemu-system-x86_64: warning: host doesn't support requested feature: CPUID[eax=80000001h].ECX.svm [bit 2] The internet says this is the remedy.	1 month ago
Michal R	a7cfc694bd	xtask: Allow to run VM integration tests without dpkg ... Debian packages are just nested archives, where the outer one is ar and the inner one is lzma2 tarball. Use Rust crates to unpack them. Co-authored-by: Tamir Duberstein <tamird@gmail.com>	2 months ago
Tamir Duberstein	0cb52e850a	xtask: tolerate curl failure when possible ... Codex sandbox forbids network access.	2 months ago
Tamir Duberstein	9ba87c661b	xtask: copy kernel config into the initramfs image ... When preparing the VM initramfs detect the `config-*` file that ships alongside the vmlinuz/modules in each kernel archive and install it under `/boot` (both as `/boot/config` and `/boot/config-<version>`). This makes the running kernel’s configuration available inside the guest for the integration tests.	2 months ago
Tamir Duberstein	5f046899b5	xtask: teach integration-test vm to consume kernel debs directly ... Bundle handling of Debian kernel archives into xtask so callers can pipe the raw `.deb` paths straight into `cargo xtask integration-test vm …`. The driver now extracts each archive into `<cache>/kernel-archives`, locates the matching `vmlinuz-*`, `lib/modules/*`, and config files, and feeds those into the initramfs build without requiring the user to pre-run dpkg/tar. With this in place we drop `.github/scripts/find_kernels.py`, simplify AGENTS.md/CI instructions to use `find test/.tmp -name '*.deb'`, remove the gnu-tar requirement we no longer need, and add `tar` as a workspace dependency for the extractor.	2 months ago
Tamir Duberstein	fab4fc44b2	xtask: reduce `fs` imports	2 months ago
Tamir Duberstein	d16711b2be	xtask: avoid variables named `cmd` and `child`	2 months ago
Tamir Duberstein	71f6176e24	xtask: ensure we actually built depmod	2 months ago
Tamir Duberstein	552b69367f	xtask: remove outdated snippet ... We handed this to QEMU in e3bfeb9dd6.	2 months ago
Tamir Duberstein	bb45904b08	xtask: patch gen_init_cpio.c ... Recent changes[0][1] have broken compatibility with macOS; add a patch to conditionally compile these snippets. Patch and compile the source unconditionally; caching only the network portion is good enough and less error prone. [0] ae18b94099 [1] 97169cd6d9	2 months ago
Tamir Duberstein	5f5305c2a8	lint all crates; enable strict pointer lints	2 months ago
Tamir Duberstein	ec3eacc1d8	Increase VM memory ... Since 6.1.0-40 we're seeing `Initramfs unpacking failed: write error`.	2 months ago
Tamir Duberstein	f08772ec2f	test-distro: enable rust backtrace	5 months ago
Tamir Duberstein	583709f6a0	appease `clippy::uninlined-format-args`	8 months ago
Tamir Duberstein	5732b2c203	test-distro: build without cross toolchain ... Make the xz2 dependency optional to allow building without a C cross compiler. This allows clippy.sh to be used on e.g. macOS more easily: ``` ./clippy.sh --target x86_64-unknown-linux-gnu --exclude-features xz2 ```	8 months ago
Tamir Duberstein	680402be0c	Revert "ci: download gen_init_cpio with authentication" ... This removes octorust which takes absolutely ages to compile and also requires native TLS libraries which in turn require a C toolchain. The latter is a pain when cross compiling from macOS. This reverts commit cc2da4a2a4.	8 months ago
Dave Tucker	abe5f743a3	feat: Refactor init into test-distro ... The init module contains a small init system for running our integration tests against a kernel. While we don't need a full-blown linux distro, we do need some utilities. Once such utility is `modprobe` which allows us to load kernel modules. Rather than create a new module for this utility, I've instead refactored `init` into `test-distro` which is a module that contains multiple binaries. The xtask code has been adjusted to ensure these binaries are inserted into the correct places in our cpio archive, as well as bringing in the kernel modules. Signed-off-by: Dave Tucker <dave@dtucker.co.uk>	9 months ago
Tamir Duberstein	f0a9f19ddc	Bump edition to 2024 ... Change FromRawTracepointArgs::arg to return T rather than *const T which seems to have been returning a dangling pointer. Arguably this is not strictly necessary; edition 2024 seems to be focused on increased strictness around unsafe code which doesn't unlock new functionality for our users. That said, this work revealed an apparent bug (see above) that we wouldn't otherwise catch due to allow-by-default lints.	9 months ago
Tamir Duberstein	4101a5a55d	Use #[expect(...)] rather than #[allow(...)] ... This is stricter, and revealed a few unused allowances.	9 months ago
Tamir Duberstein	d1457acc6d	ci: cache downloads ... We're seeing 429 from Github trying to download gen_init_cpio, so cache it using actions cache. Since I'm here add this for kernel images as well to save time waiting on slow Debian servers.	12 months ago
Tamir Duberstein	cc2da4a2a4	ci: download gen_init_cpio with authentication ... The raw endpoint[0] now[1] seems to return HTTP 429 on the first request and unauthenticated API limits are exceeded after one request (so one of ubuntu/macos builders fails). Hopefully this works with authentication. Link: https://raw.githubusercontent.com/torvalds/linux/refs/heads/master/usr/gen_init_cpio.c [0] Link: https://github.com/orgs/community/discussions/146957 [1]	1 year ago
Tamir Duberstein	fd00b39f09	Enable unwinding in userspace ... Unwinding gives us more information, so we shouldn't disable it globally. It is already disabled for BPF targets via the target configs in rustc itself. This complicates the clippy invocation somewhat, so put it in a shell script for developer as well as CI use.	1 year ago
Tamir Duberstein	e3bfeb9dd6	Allow QEMU to fall back	1 year ago
Tamir Duberstein	f9b34fe76f	qemu: remove bios argument ... I did this for arm64 because we'd get a black screen without it but I have now confirmed that console=ttyAMA0 solves that problem. I don't remember why I did it for x86.	1 year ago
Dave Tucker	0c58bb66b6	integration-test: Fix build.rs output ... The cargo::warning seems to ignore output after a newline. Iterate over the entire rendered message and print it line-by-line. Signed-off-by: Dave Tucker <dave@dtucker.co.uk>	2 years ago
Tamir Duberstein	7a4c6153a0	xtask: terminate QEMU on "RCU grace-period kthread stack dump" ... See https://github.com/aya-rs/bpf-linker/actions/runs/7067897954/job/19241830198	2 years ago
Tamir Duberstein	42cc175aeb	xtask: attempt to open /dev/kvm ... We're seeing test failures where KVM is present but we aren't able to use it. See https://github.com/actions/runner-images/issues/7670#issuecomment-1760184162.	2 years ago
Tamir Duberstein	5392f9821d	xtask: terminate QEMU on "BUG: soft lockup" ... See https://github.com/aya-rs/aya/actions/runs/6329828507/job/17190931752. Unlike on kernel panic this message prints periodically so it is permitted to print twice before QEMU is killed.	2 years ago
Tamir Duberstein	fe13b2eb41	xtask: remove useless copy ... /tmp/initrd.img is unused.	2 years ago
Tamir Duberstein	782eb85d4a	xtask: extract `Errors` type ... This produces better errors in `cargo xtask public-api` because before this change we'd print errors as display, which didn't show context. Before: ``` Error: public API errors: aya failed to check public API: public_api::Builder::build aya-obj failed to check public API: public_api::Builder::build aya-log failed to check public API: public_api::Builder::build aya-log-common failed to check public API: public_api::Builder::build aya-log-parser failed to check public API: public_api::Builder::build aya-tool failed to check public API: public_api::Builder::build aya-bpf failed to check public API: public_api::Builder::build aya-bpf-bindings failed to check public API: public_api::Builder::build aya-bpf-cty failed to check public API: public_api::Builder::build aya-bpf-macros failed to check public API: public_api::Builder::build aya-log-ebpf-macros failed to check public API: public_api::Builder::build ``` After: ``` Error: aya failed to check public API Caused by: 0: public_api::Builder::build 1: unknown variant `type_alias`, expected one of `module`, `extern_crate`, `import`, `struct`, `struct_field`, `union`, `enum`, `variant`, `function`, `typedef`, `opaque_ty`, `constant`, `trait`, `trait_alias`, `impl`, `static`, `foreign_type`, `macro`, `proc_attribute`, `proc_derive`, `assoc_const`, `assoc_type`, `primitive`, `keyword` at line 1 column 3082463 aya-obj failed to check public API Caused by: 0: public_api::Builder::build 1: unknown variant `type_alias`, expected one of `module`, `extern_crate`, `import`, `union`, `struct`, `struct_field`, `enum`, `variant`, `function`, `trait`, `trait_alias`, `impl`, `typedef`, `opaque_ty`, `constant`, `static`, `foreign_type`, `macro`, `proc_macro`, `primitive`, `assoc_const`, `assoc_type` at line 1 column 129355 aya-log failed to check public API Caused by: 0: public_api::Builder::build 1: unknown variant `type_alias`, expected one of `module`, `extern_crate`, `import`, `struct`, `struct_field`, `union`, `enum`, `variant`, `function`, `typedef`, `opaque_ty`, `constant`, `trait`, `trait_alias`, `impl`, `static`, `foreign_type`, `macro`, `proc_attribute`, `proc_derive`, `assoc_const`, `assoc_type`, `primitive`, `keyword` at line 1 column 311910 aya-log-common failed to check public API Caused by: 0: public_api::Builder::build 1: unknown variant `type_alias`, expected one of `module`, `extern_crate`, `import`, `union`, `struct`, `struct_field`, `enum`, `variant`, `function`, `trait`, `trait_alias`, `impl`, `typedef`, `opaque_ty`, `constant`, `static`, `foreign_type`, `macro`, `proc_macro`, `primitive`, `assoc_const`, `assoc_type` at line 1 column 130456 aya-log-parser failed to check public API Caused by: 0: public_api::Builder::build 1: unknown variant `type_alias`, expected one of `module`, `extern_crate`, `import`, `struct`, `struct_field`, `union`, `enum`, `variant`, `function`, `typedef`, `opaque_ty`, `constant`, `trait`, `trait_alias`, `impl`, `static`, `foreign_type`, `macro`, `proc_attribute`, `proc_derive`, `assoc_const`, `assoc_type`, `primitive`, `keyword` at line 1 column 204930 aya-tool failed to check public API Caused by: 0: public_api::Builder::build 1: unknown variant `type_alias`, expected one of `module`, `extern_crate`, `import`, `struct`, `struct_field`, `union`, `enum`, `variant`, `function`, `typedef`, `opaque_ty`, `constant`, `trait`, `trait_alias`, `impl`, `static`, `foreign_type`, `macro`, `proc_attribute`, `proc_derive`, `assoc_const`, `assoc_type`, `primitive`, `keyword` at line 1 column 234519 aya-bpf failed to check public API Caused by: 0: public_api::Builder::build 1: unknown variant `type_alias`, expected one of `module`, `extern_crate`, `import`, `struct`, `struct_field`, `union`, `enum`, `variant`, `function`, `typedef`, `opaque_ty`, `constant`, `trait`, `trait_alias`, `impl`, `static`, `foreign_type`, `macro`, `proc_attribute`, `proc_derive`, `assoc_const`, `assoc_type`, `primitive`, `keyword` at line 1 column 741697 aya-bpf-bindings failed to check public API Caused by: 0: public_api::Builder::build 1: unknown variant `type_alias`, expected one of `module`, `extern_crate`, `import`, `union`, `struct`, `struct_field`, `enum`, `variant`, `function`, `trait`, `trait_alias`, `impl`, `typedef`, `opaque_ty`, `constant`, `static`, `foreign_type`, `macro`, `proc_macro`, `primitive`, `assoc_const`, `assoc_type` at line 1 column 112445 aya-bpf-cty failed to check public API Caused by: 0: public_api::Builder::build 1: unknown variant `type_alias`, expected one of `module`, `extern_crate`, `import`, `union`, `struct`, `struct_field`, `enum`, `variant`, `function`, `trait`, `trait_alias`, `impl`, `typedef`, `opaque_ty`, `constant`, `static`, `foreign_type`, `macro`, `proc_macro`, `primitive`, `assoc_const`, `assoc_type` at line 1 column 315 aya-bpf-macros failed to check public API Caused by: 0: public_api::Builder::build 1: unknown variant `type_alias`, expected one of `module`, `extern_crate`, `import`, `struct`, `struct_field`, `union`, `enum`, `variant`, `function`, `typedef`, `opaque_ty`, `constant`, `trait`, `trait_alias`, `impl`, `static`, `foreign_type`, `macro`, `proc_attribute`, `proc_derive`, `assoc_const`, `assoc_type`, `primitive`, `keyword` at line 1 column 186226 aya-log-ebpf-macros failed to check public API Caused by: 0: public_api::Builder::build 1: unknown variant `type_alias`, expected one of `module`, `extern_crate`, `import`, `struct`, `struct_field`, `union`, `enum`, `variant`, `function`, `typedef`, `opaque_ty`, `constant`, `trait`, `trait_alias`, `impl`, `static`, `foreign_type`, `macro`, `proc_attribute`, `proc_derive`, `assoc_const`, `assoc_type`, `primitive`, `keyword` at line 1 column 158055 ```	2 years ago
Tamir Duberstein	7e14214f47	xtask: add noapic to kernel parameters ... This might prevent some kernel panics.	2 years ago
Tamir Duberstein	de65ba0067	xtask: watch for kernel panic in stdout too ... Seems unclear whether kernel panics go to stdout or stderr, so do them both.	2 years ago
Tamir Duberstein	58ba66c003	xtask: watch for kernel panics on stderr ... It seems these go to stderr, not stdout. Use `Ctrl-A x` to shut QEMU down if a panic is seen.	2 years ago
Tamir Duberstein	82a77bc83d	integration-test: Implement running on VMs ... Implements running integration tests on multiple VMs with arbitrary kernel images using `cargo xtask integration-test vm ...`. This changes our coverage from 6.2 to 6.1 and 6.4.	2 years ago
Tamir Duberstein	dc9f72adf0	test,xtask: Simplify ExitStatus handling	2 years ago
Tamir Duberstein	a6b1fb9a1e	xtask: allow arbitrary flags to cargo build	2 years ago
Tamir Duberstein	74fc50bf7e	integration-test: shuttle stdio to user ... Trampoline cargo-in-cargo stdio through cargo:warning to ensure the user sees all the output. Use bpf-linker from git in CI so we can see what's going on there.	2 years ago
Tamir Duberstein	e276c07f73	integration-ebpf: invalidate on bpf-linker ... Extract the symlink-to-bpf-linker logic from integration-test to xtask and use it in a new build script in integration-ebpf, causing ebpf probes to be rebuilt when bpf-linker changes. Previously bpf-linker changes would rebuild integration-test, but not integration-ebpf, resulting in stale tests. Note that this still doesn't address the possibility that a new bpf-linker is added to the PATH ahead of the cached one. Solving this in the general case would require rebuild-if-changed-env=PATH *and* rebuild-if-changed={every-directory-in-PATH} which would likely mean far too much cache invalidation.	2 years ago
Tamir Duberstein	6ac1320707	integration-test: build "fake" by default ... Use the environment variable AYA_BUILD_INTEGRATION_BPF to indicate to the build script that it should *actually* build bpf, otherwise emitting empty files. This allows metadata builds to skip costly build steps without sacrificing ergonomics; all compile-time tools such as cargo clippy work out of the box. Cargo even gives each of these builds (depending on the value of the environment variable) its own cache key, so they do not invalidate each other when the user alternates between metadata and real builds. This allows the lint action to move out of the VM.	2 years ago
Tamir Duberstein	9086265ac0	xtask: reimplement build-integration-test ... This command builds the integration test binaries and prints their paths to stdout.	2 years ago
Tamir Duberstein	3d463a3610	integration-test: compile Rust probes using build.rs	2 years ago
Tamir Duberstein	bc9f059d53	xtask: inline build_ebpf	2 years ago
Tamir Duberstein	8c61fc9ea6	integration-test: compile C probes using build.rs ... - Add libbpf as a submodule. This prevents having to plumb its location around (which can't be passed to Cargo build scripts) and also controls the version against which codegen has run. - Move bpf written in C to the integration-test crate and define constants for each probe. - Remove magic; each C source file must be directly enumerated in the build script and in lib.rs.	2 years ago
Tamir Duberstein	b0a4ab5f20	xtask: Standardize command logging ... Don't run `cargo build --verbose`; it's too noisy.	2 years ago
Tamir Duberstein	9ca0af1a79	integration-test: Remove integration-test-macros ... This doesn't add any value; use `cargo build --tests` with `--message-format=json` instead; parse the output using `cargo_metadata` to discover the location of the test binary. Move test/integration-test/src/tests -> test/integration-test/tests to conform to https://doc.rust-lang.org/book/ch11-03-test-organization.html#integration-tests.	2 years ago
Tamir Duberstein	de1fe1f5e1	xtask: Avoid lossy conversions, spurious vectors	2 years ago