5 Commits (e9a099f332ee0362f77bdd2ade5c76ddfccbf018)

Author	SHA1	Message	Date
Tamir Duberstein	e9a099f332	bpf: Remove builtin global functions ... This commit removes memset and memcpy, relying instead on implementations provided by std/compiler-builtins. This commit adds `#![no_builtins]` to all the BPF programs written in Rust, and the same should be propagated to aya-template and all examples in the book and elsewhere before this commit is merged. It turns out that without the `#![no_builtins]` annotation rustc generates LLVM IR that calls LLVM intrinsics rather than libcalls. These may end up as libcalls after lowering, but not before emitting errors in BPF lowering[0]. This works thanks to https://github.com/rust-lang/rust/pull/113716 which causes `#![no_builtins]` to behave similarly to `-fno-builtin` in clang, which was added in https://reviews.llvm.org/D68028 with similar motivation. This commit implies that we now require rustc nightly >= 2023-07-20. [0] https://github.com/llvm/llvm-project/blob/7b2745b/llvm/lib/Target/BPF/BPFISelLowering.cpp#L472-L474	2 years ago
Tamir Duberstein	ad460879ef	integration-test: replace macro with function ... There's just no need for a macro here.	2 years ago
Tamir Duberstein	8cee3f8b01	integration-test: distinguish between success and noop ... These tests previously produced the same result on certain failures as they did on success.	2 years ago
Tamir Duberstein	e621a09181	Clippy over tests and integration-ebpf ... Replace all `assert!(matches!(..))` with `assert_matches!(..)`. Remove the now-unused build-integration-test xtask command whose logic doesn't match that of the build-and-run command.	2 years ago
Alessandro Decina	11c227743d	bpf: improve bpf_probe_read_kernel_str_bytes and bpf_probe_read_user_str_bytes ... This change does a few things: - it fixes a bug in the wrappers, where we were expecting the kernel to return len=1 for b"\0" where it instead returns 0 and doesn't write out the NULL terminator - it makes the helpers more robust by hardcoding bound checks in assembly so that LLVM optimizations can't transform the checks in a way that the verifier can't understand. - it adds integration tests	2 years ago