31 Commits (fd00b39f09fc082a7fe5988c5ebc61d6380dbba6)

Author	SHA1	Message	Date
Tamir Duberstein	fd00b39f09	Enable unwinding in userspace ... Unwinding gives us more information, so we shouldn't disable it globally. It is already disabled for BPF targets via the target configs in rustc itself. This complicates the clippy invocation somewhat, so put it in a shell script for developer as well as CI use.	2 months ago
Tamir Duberstein	e3bfeb9dd6	Allow QEMU to fall back	3 months ago
Tamir Duberstein	f9b34fe76f	qemu: remove bios argument ... I did this for arm64 because we'd get a black screen without it but I have now confirmed that console=ttyAMA0 solves that problem. I don't remember why I did it for x86.	3 months ago
Dave Tucker	0c58bb66b6	integration-test: Fix build.rs output ... The cargo::warning seems to ignore output after a newline. Iterate over the entire rendered message and print it line-by-line. Signed-off-by: Dave Tucker <dave@dtucker.co.uk>	11 months ago
Tamir Duberstein	7a4c6153a0	xtask: terminate QEMU on "RCU grace-period kthread stack dump" ... See https://github.com/aya-rs/bpf-linker/actions/runs/7067897954/job/19241830198	1 year ago
Tamir Duberstein	42cc175aeb	xtask: attempt to open /dev/kvm ... We're seeing test failures where KVM is present but we aren't able to use it. See https://github.com/actions/runner-images/issues/7670#issuecomment-1760184162.	1 year ago
Tamir Duberstein	5392f9821d	xtask: terminate QEMU on "BUG: soft lockup" ... See https://github.com/aya-rs/aya/actions/runs/6329828507/job/17190931752. Unlike on kernel panic this message prints periodically so it is permitted to print twice before QEMU is killed.	1 year ago
Tamir Duberstein	fe13b2eb41	xtask: remove useless copy ... /tmp/initrd.img is unused.	1 year ago
Tamir Duberstein	782eb85d4a	xtask: extract `Errors` type ... This produces better errors in `cargo xtask public-api` because before this change we'd print errors as display, which didn't show context. Before: ``` Error: public API errors: aya failed to check public API: public_api::Builder::build aya-obj failed to check public API: public_api::Builder::build aya-log failed to check public API: public_api::Builder::build aya-log-common failed to check public API: public_api::Builder::build aya-log-parser failed to check public API: public_api::Builder::build aya-tool failed to check public API: public_api::Builder::build aya-bpf failed to check public API: public_api::Builder::build aya-bpf-bindings failed to check public API: public_api::Builder::build aya-bpf-cty failed to check public API: public_api::Builder::build aya-bpf-macros failed to check public API: public_api::Builder::build aya-log-ebpf-macros failed to check public API: public_api::Builder::build ``` After: ``` Error: aya failed to check public API Caused by: 0: public_api::Builder::build 1: unknown variant `type_alias`, expected one of `module`, `extern_crate`, `import`, `struct`, `struct_field`, `union`, `enum`, `variant`, `function`, `typedef`, `opaque_ty`, `constant`, `trait`, `trait_alias`, `impl`, `static`, `foreign_type`, `macro`, `proc_attribute`, `proc_derive`, `assoc_const`, `assoc_type`, `primitive`, `keyword` at line 1 column 3082463 aya-obj failed to check public API Caused by: 0: public_api::Builder::build 1: unknown variant `type_alias`, expected one of `module`, `extern_crate`, `import`, `union`, `struct`, `struct_field`, `enum`, `variant`, `function`, `trait`, `trait_alias`, `impl`, `typedef`, `opaque_ty`, `constant`, `static`, `foreign_type`, `macro`, `proc_macro`, `primitive`, `assoc_const`, `assoc_type` at line 1 column 129355 aya-log failed to check public API Caused by: 0: public_api::Builder::build 1: unknown variant `type_alias`, expected one of `module`, `extern_crate`, `import`, `struct`, `struct_field`, `union`, `enum`, `variant`, `function`, `typedef`, `opaque_ty`, `constant`, `trait`, `trait_alias`, `impl`, `static`, `foreign_type`, `macro`, `proc_attribute`, `proc_derive`, `assoc_const`, `assoc_type`, `primitive`, `keyword` at line 1 column 311910 aya-log-common failed to check public API Caused by: 0: public_api::Builder::build 1: unknown variant `type_alias`, expected one of `module`, `extern_crate`, `import`, `union`, `struct`, `struct_field`, `enum`, `variant`, `function`, `trait`, `trait_alias`, `impl`, `typedef`, `opaque_ty`, `constant`, `static`, `foreign_type`, `macro`, `proc_macro`, `primitive`, `assoc_const`, `assoc_type` at line 1 column 130456 aya-log-parser failed to check public API Caused by: 0: public_api::Builder::build 1: unknown variant `type_alias`, expected one of `module`, `extern_crate`, `import`, `struct`, `struct_field`, `union`, `enum`, `variant`, `function`, `typedef`, `opaque_ty`, `constant`, `trait`, `trait_alias`, `impl`, `static`, `foreign_type`, `macro`, `proc_attribute`, `proc_derive`, `assoc_const`, `assoc_type`, `primitive`, `keyword` at line 1 column 204930 aya-tool failed to check public API Caused by: 0: public_api::Builder::build 1: unknown variant `type_alias`, expected one of `module`, `extern_crate`, `import`, `struct`, `struct_field`, `union`, `enum`, `variant`, `function`, `typedef`, `opaque_ty`, `constant`, `trait`, `trait_alias`, `impl`, `static`, `foreign_type`, `macro`, `proc_attribute`, `proc_derive`, `assoc_const`, `assoc_type`, `primitive`, `keyword` at line 1 column 234519 aya-bpf failed to check public API Caused by: 0: public_api::Builder::build 1: unknown variant `type_alias`, expected one of `module`, `extern_crate`, `import`, `struct`, `struct_field`, `union`, `enum`, `variant`, `function`, `typedef`, `opaque_ty`, `constant`, `trait`, `trait_alias`, `impl`, `static`, `foreign_type`, `macro`, `proc_attribute`, `proc_derive`, `assoc_const`, `assoc_type`, `primitive`, `keyword` at line 1 column 741697 aya-bpf-bindings failed to check public API Caused by: 0: public_api::Builder::build 1: unknown variant `type_alias`, expected one of `module`, `extern_crate`, `import`, `union`, `struct`, `struct_field`, `enum`, `variant`, `function`, `trait`, `trait_alias`, `impl`, `typedef`, `opaque_ty`, `constant`, `static`, `foreign_type`, `macro`, `proc_macro`, `primitive`, `assoc_const`, `assoc_type` at line 1 column 112445 aya-bpf-cty failed to check public API Caused by: 0: public_api::Builder::build 1: unknown variant `type_alias`, expected one of `module`, `extern_crate`, `import`, `union`, `struct`, `struct_field`, `enum`, `variant`, `function`, `trait`, `trait_alias`, `impl`, `typedef`, `opaque_ty`, `constant`, `static`, `foreign_type`, `macro`, `proc_macro`, `primitive`, `assoc_const`, `assoc_type` at line 1 column 315 aya-bpf-macros failed to check public API Caused by: 0: public_api::Builder::build 1: unknown variant `type_alias`, expected one of `module`, `extern_crate`, `import`, `struct`, `struct_field`, `union`, `enum`, `variant`, `function`, `typedef`, `opaque_ty`, `constant`, `trait`, `trait_alias`, `impl`, `static`, `foreign_type`, `macro`, `proc_attribute`, `proc_derive`, `assoc_const`, `assoc_type`, `primitive`, `keyword` at line 1 column 186226 aya-log-ebpf-macros failed to check public API Caused by: 0: public_api::Builder::build 1: unknown variant `type_alias`, expected one of `module`, `extern_crate`, `import`, `struct`, `struct_field`, `union`, `enum`, `variant`, `function`, `typedef`, `opaque_ty`, `constant`, `trait`, `trait_alias`, `impl`, `static`, `foreign_type`, `macro`, `proc_attribute`, `proc_derive`, `assoc_const`, `assoc_type`, `primitive`, `keyword` at line 1 column 158055 ```	1 year ago
Tamir Duberstein	7e14214f47	xtask: add noapic to kernel parameters ... This might prevent some kernel panics.	2 years ago
Tamir Duberstein	de65ba0067	xtask: watch for kernel panic in stdout too ... Seems unclear whether kernel panics go to stdout or stderr, so do them both.	2 years ago
Tamir Duberstein	58ba66c003	xtask: watch for kernel panics on stderr ... It seems these go to stderr, not stdout. Use `Ctrl-A x` to shut QEMU down if a panic is seen.	2 years ago
Tamir Duberstein	82a77bc83d	integration-test: Implement running on VMs ... Implements running integration tests on multiple VMs with arbitrary kernel images using `cargo xtask integration-test vm ...`. This changes our coverage from 6.2 to 6.1 and 6.4.	2 years ago
Tamir Duberstein	dc9f72adf0	test,xtask: Simplify ExitStatus handling	2 years ago
Tamir Duberstein	a6b1fb9a1e	xtask: allow arbitrary flags to cargo build	2 years ago
Tamir Duberstein	74fc50bf7e	integration-test: shuttle stdio to user ... Trampoline cargo-in-cargo stdio through cargo:warning to ensure the user sees all the output. Use bpf-linker from git in CI so we can see what's going on there.	2 years ago
Tamir Duberstein	e276c07f73	integration-ebpf: invalidate on bpf-linker ... Extract the symlink-to-bpf-linker logic from integration-test to xtask and use it in a new build script in integration-ebpf, causing ebpf probes to be rebuilt when bpf-linker changes. Previously bpf-linker changes would rebuild integration-test, but not integration-ebpf, resulting in stale tests. Note that this still doesn't address the possibility that a new bpf-linker is added to the PATH ahead of the cached one. Solving this in the general case would require rebuild-if-changed-env=PATH *and* rebuild-if-changed={every-directory-in-PATH} which would likely mean far too much cache invalidation.	2 years ago
Tamir Duberstein	6ac1320707	integration-test: build "fake" by default ... Use the environment variable AYA_BUILD_INTEGRATION_BPF to indicate to the build script that it should *actually* build bpf, otherwise emitting empty files. This allows metadata builds to skip costly build steps without sacrificing ergonomics; all compile-time tools such as cargo clippy work out of the box. Cargo even gives each of these builds (depending on the value of the environment variable) its own cache key, so they do not invalidate each other when the user alternates between metadata and real builds. This allows the lint action to move out of the VM.	2 years ago
Tamir Duberstein	9086265ac0	xtask: reimplement build-integration-test ... This command builds the integration test binaries and prints their paths to stdout.	2 years ago
Tamir Duberstein	3d463a3610	integration-test: compile Rust probes using build.rs	2 years ago
Tamir Duberstein	bc9f059d53	xtask: inline build_ebpf	2 years ago
Tamir Duberstein	8c61fc9ea6	integration-test: compile C probes using build.rs ... - Add libbpf as a submodule. This prevents having to plumb its location around (which can't be passed to Cargo build scripts) and also controls the version against which codegen has run. - Move bpf written in C to the integration-test crate and define constants for each probe. - Remove magic; each C source file must be directly enumerated in the build script and in lib.rs.	2 years ago
Tamir Duberstein	b0a4ab5f20	xtask: Standardize command logging ... Don't run `cargo build --verbose`; it's too noisy.	2 years ago
Tamir Duberstein	9ca0af1a79	integration-test: Remove integration-test-macros ... This doesn't add any value; use `cargo build --tests` with `--message-format=json` instead; parse the output using `cargo_metadata` to discover the location of the test binary. Move test/integration-test/src/tests -> test/integration-test/tests to conform to https://doc.rust-lang.org/book/ch11-03-test-organization.html#integration-tests.	2 years ago
Tamir Duberstein	de1fe1f5e1	xtask: Avoid lossy conversions, spurious vectors	2 years ago
Tamir Duberstein	ff86f1385c	Remove dependency on bpftool in integration tests	2 years ago
Michal Rostecki	ed9c2a1780	integration-tests: Build eBPF programs always with release profile ... Also, add the `codegen-unit` option to the profile.	2 years ago
Dmitry Savintsev	055d94f58b	fix uninlined_format_args clippy issues	2 years ago
Dmitry Savintsev	22340764a3	upgrade clap to 4.x	2 years ago
Dave Tucker	5e6b75a29a	xtask: Fix integration-test command ... Signed-off-by: Dave Tucker <dave@dtucker.co.uk>	2 years ago
Dave Tucker	79101e748a	test: Replace RTF with Rust ... This commit replaces the existing RTF test runner with a simple rust binary package called - integration-test. integration-test depends on integration-ebpf, which contains test eBPF code written in Rust and C. `cargo xtask build-integration-test-ebpf` can be used to build this code and supress rust-analyzer warnings. It does require `bpf-linker`, but that is highly likely to be available to developers of Aya. It also requires a checkout of `libbpf` to extract headers like bpf-helpers.h. Since everything is compiled into a single binary, it can be run be run locally using `cargo xtask integration-test` or remotely using `./run.sh` which re-uses the bash script from the old test framework to spawn a VM in which to run the tests. Signed-off-by: Dave Tucker <dave@dtucker.co.uk>	3 years ago