Merge pull request #77 from dmitris/crossplat

Remove unix-specific executor in xtask
pull/78/head
Michal Rostecki 2 years ago committed by GitHub
commit 80a7c5b53c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

@ -1,4 +1,4 @@
use std::{os::unix::process::CommandExt, process::Command}; use std::process::Command;
use anyhow::Context as _; use anyhow::Context as _;
use clap::Parser; use clap::Parser;
@ -57,11 +57,14 @@ pub fn run(opts: Options) -> Result<(), anyhow::Error> {
args.push(bin_path.as_str()); args.push(bin_path.as_str());
args.append(&mut run_args); args.append(&mut run_args);
// spawn the command // run the command
let err = Command::new(args.first().expect("No first argument")) let status = Command::new(args.first().expect("No first argument"))
.args(args.iter().skip(1)) .args(args.iter().skip(1))
.exec(); .status()
.expect("failed to run the command");
// we shouldn't get here unless the command failed to spawn if !status.success() {
Err(anyhow::Error::from(err).context(format!("Failed to run `{}`", args.join(" ")))) anyhow::bail!("Failed to run `{}`", args.join(" "));
}
Ok(())
} }

Loading…
Cancel
Save