structopt was merged into clap (starting from clap 3.0), therefore
becoming a deprecated project.
Signed-off-by: Michal Rostecki <vadorovsky@gmail.com>
eBPF programs cannot be debugged and those ones built with the default
dev profile are often annoying the verifier. Therefore it doesn't make
sense to compile not optimized eBPF objects.
However, we still want to let people to use the dev profile, especially
in the future when we want to get rid of xtask by using cargo binary
dependencies[0]. The trick is to have no real difference between dev and
release profile in eBPF.
This change doesn't affect the userspace part which still is going to
contain debug symbols when built with dev profile.
[0] https://rust-lang.github.io/rfcs/3028-cargo-binary-dependencies.html
Signed-off-by: Michal Rostecki <vadorovsky@gmail.com>
Current `[a-z_]+` regex allows upper case such as `NET_dev`, `netDev`
or even `NET_DEV` when one of `a-z` or `_` contains in the string. It
should be disallowed.
This patch fixes it.
This change removes the differentiation between release and dev profiles
for eBPF programs. There is no way eBPF programs can be debugged and
building them with dev profile just makes them slower and often unable
to be verified. They should be always built with the release profile.
After this change, `cargo xtask build-ebpf` is going to build eBPF
programs with release profile. And the userspace program is going to
include eBPF program bytes from target/release/. Regardless of which
profile is being used in the userspace program.
`cargo xtask build-ebpf` has the --profile argument which can be
optionally used (i.e. for user-defined profiles), but by default the
value of that option is `release`.
Signed-off-by: Michal Rostecki <mrostecki@opensuse.org>
Avoid unused_imports warning for std::convert::TryFrom.
Conditionally import it only when it is needed -
in sk_msg programs.
remove unused `std::convert::TryFrom` import to avoid the warning in the generated projects:
```
warning: unused import: `TryFrom`
--> myapp/src/main.rs:4:15
|
4 | convert::{TryFrom,TryInto},
| ^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
warning: `myapp` (bin "myapp") generated 1 warning
```
This new subcommand provides a convenient way to run your aya application.
Features include:
- automatic compilation of userspace + bpf code
- support for user-defined runners, defaulting to `sudo -E` for convenience
- no need to run `sudo cargo run` (gross) or `sudo target/debug/myapp` (also gross),
it just works
- an optional `-p` flag which automatically supplies the correct --path flag to the
application
- support for trailing args after a final -- which are passed to the application,
cargo run-style
My original patch was broken for crates with names-like-this, since it would incorrectly
add underscores instead of dashes to the pathname. This patch fixes the problem.
Alessandro Decina
Michal Rostecki
Kenjiro Nakayama
Dave Tucker
Marcus Weiner
Dmitry Savintsev
Michal Rostecki
Dmitry Savintsev
William Findlay