Add macos-latest

There's no way to get hardware acceleration on arm64 at all, so let's at
least make sure our stuff keeps working on macOS.
pull/1394/head
Tamir Duberstein 4 days ago
parent 46221ad11d
commit 7a8ad146f4
No known key found for this signature in database

@ -218,10 +218,10 @@ jobs:
matrix: matrix:
# We don't have a fast solution for running virtualized integration # We don't have a fast solution for running virtualized integration
# tests on arm64 because: # tests on arm64 because:
# - Github broke nested virtualization on macos-15-intel (see below). # - GitHub Ubuntu arm64 runners don't support nested virtualization (see
# - Github arm64 runners don't support nested virtualization (see
# https://github.com/orgs/community/discussions/148648#discussioncomment-11863547). # https://github.com/orgs/community/discussions/148648#discussioncomment-11863547).
# - Unlike HVF, KVM doesn't emulate CPUs. # - GitHub macOS arm64 runners don't support nested virtualization (see
# https://docs.github.com/en/actions/reference/runners/github-hosted-runners#limitations-for-arm64-macos-runners).
# #
# So we spin a runner for every arm64 kernel to avoid waiting 20 minutes # So we spin a runner for every arm64 kernel to avoid waiting 20 minutes
# for CI. We use arm64 runners to avoid cross-compilation. # for CI. We use arm64 runners to avoid cross-compilation.
@ -234,15 +234,11 @@ jobs:
skip-local: skip-local:
- true - true
include: include:
# TODO(https://github.com/actions/runner-images/issues/13277): Reenable when fixed. - os: macos-latest
# macos-15 is arm64[0] which doesn't support nested # Just one kernel to keep things fast. We just want to keep things from rotting on
# virtualization[1]. # macOS. We use amd64 because otherwise qemu tries to use HVF and hits a hard error:
# # qemu-system-aarch64: -accel hvf: Error: ret = HV_UNSUPPORTED (0xfae9400f, at ../target/arm/hvf/hvf.c:956)
# [0] https://github.com/actions/runner-images#available-images download-kernel-images: amd64 5.10
#
# [1] https://docs.github.com/en/actions/reference/runners/github-hosted-runners#limitations-for-arm64-macos-runners
#
# - os: macos-15-intel
# We don't use ubuntu-latest because we care about the apt packages available. # We don't use ubuntu-latest because we care about the apt packages available.
- os: ubuntu-24.04 - os: ubuntu-24.04

Loading…
Cancel
Save