Replace matches with assert_matches

The matches crate has been archived now that `matches!` is in std.
However `assert_matches!` is still unstable in std, and the
assert_matches crate provides a more expressive form:

```
assert_matches!(foo, Ok(bar) => {
  assert_eq!(bar, baz);
});
```
pull/656/head
Tamir Duberstein 1 year ago
parent b875f83f22
commit 961f45da37
No known key found for this signature in database

@ -2,7 +2,7 @@
name = "aya-obj" name = "aya-obj"
version = "0.1.0" version = "0.1.0"
description = "An eBPF object file parsing library with BTF and relocation support." description = "An eBPF object file parsing library with BTF and relocation support."
keywords = ["ebpf", "bpf", "btf", "elf", "object"] keywords = ["bpf", "btf", "ebpf", "elf", "object"]
license = "MIT OR Apache-2.0" license = "MIT OR Apache-2.0"
authors = ["The Aya Contributors"] authors = ["The Aya Contributors"]
repository = "https://github.com/aya-rs/aya" repository = "https://github.com/aya-rs/aya"
@ -13,13 +13,16 @@ edition = "2021"
[dependencies] [dependencies]
bytes = "1" bytes = "1"
log = "0.4" log = "0.4"
object = { version = "0.31", default-features = false, features = ["read_core", "elf"] } object = { version = "0.31", default-features = false, features = [
"elf",
"read_core",
] }
hashbrown = { version = "0.14" } hashbrown = { version = "0.14" }
thiserror = { version = "1", default-features = false } thiserror = { version = "1", default-features = false }
core-error = { version = "0.0.0" } core-error = { version = "0.0.0" }
[dev-dependencies] [dev-dependencies]
matches = "0.1.8" assert_matches = "1.5.0"
rbpf = "0.2.0" rbpf = "0.2.0"
[features] [features]

@ -1486,7 +1486,7 @@ pub fn copy_instructions(data: &[u8]) -> Result<Vec<bpf_insn>, ParseError> {
#[cfg(test)] #[cfg(test)]
mod tests { mod tests {
use alloc::vec; use alloc::vec;
use matches::assert_matches; use assert_matches::assert_matches;
use object::Endianness; use object::Endianness;
use super::*; use super::*;

@ -29,8 +29,8 @@ thiserror = "1"
tokio = { version = "1.24.0", features = ["rt"], optional = true } tokio = { version = "1.24.0", features = ["rt"], optional = true }
[dev-dependencies] [dev-dependencies]
assert_matches = "1.5.0"
futures = { version = "0.3.12", default-features = false, features = ["std"] } futures = { version = "0.3.12", default-features = false, features = ["std"] }
matches = "0.1.8"
tempfile = "3" tempfile = "3"
[features] [features]

@ -88,8 +88,8 @@ mod tests {
obj::{self, maps::LegacyMap, BpfSectionKind}, obj::{self, maps::LegacyMap, BpfSectionKind},
sys::{override_syscall, SysResult, Syscall}, sys::{override_syscall, SysResult, Syscall},
}; };
use assert_matches::assert_matches;
use libc::{EFAULT, ENOENT}; use libc::{EFAULT, ENOENT};
use matches::assert_matches;
use std::io; use std::io;
fn new_obj_map() -> obj::Map { fn new_obj_map() -> obj::Map {

@ -107,8 +107,8 @@ impl<T: Borrow<MapData>, K: Pod, V: Pod> IterableMap<K, V> for HashMap<T, K, V>
mod tests { mod tests {
use std::io; use std::io;
use assert_matches::assert_matches;
use libc::{EFAULT, ENOENT}; use libc::{EFAULT, ENOENT};
use matches::assert_matches;
use crate::{ use crate::{
bpf_map_def, bpf_map_def,

@ -207,8 +207,8 @@ mod tests {
obj::{self, maps::LegacyMap, BpfSectionKind}, obj::{self, maps::LegacyMap, BpfSectionKind},
sys::{override_syscall, SysResult, Syscall}, sys::{override_syscall, SysResult, Syscall},
}; };
use assert_matches::assert_matches;
use libc::{EFAULT, ENOENT}; use libc::{EFAULT, ENOENT};
use matches::assert_matches;
use std::{io, mem, net::Ipv4Addr}; use std::{io, mem, net::Ipv4Addr};
fn new_obj_map() -> obj::Map { fn new_obj_map() -> obj::Map {

@ -842,8 +842,8 @@ impl<T: Pod> Deref for PerCpuValues<T> {
#[cfg(test)] #[cfg(test)]
mod tests { mod tests {
use assert_matches::assert_matches;
use libc::EFAULT; use libc::EFAULT;
use matches::assert_matches;
use crate::{ use crate::{
bpf_map_def, bpf_map_def,

@ -319,7 +319,7 @@ mod tests {
generated::perf_event_mmap_page, generated::perf_event_mmap_page,
sys::{override_syscall, Syscall, TEST_MMAP_RET}, sys::{override_syscall, Syscall, TEST_MMAP_RET},
}; };
use matches::assert_matches; use assert_matches::assert_matches;
use std::{fmt::Debug, mem}; use std::{fmt::Debug, mem};
const PAGE_SIZE: usize = 4096; const PAGE_SIZE: usize = 4096;

@ -353,7 +353,7 @@ pub enum LinkError {
#[cfg(test)] #[cfg(test)]
mod tests { mod tests {
use matches::assert_matches; use assert_matches::assert_matches;
use std::{cell::RefCell, fs::File, mem, os::unix::io::AsRawFd, rc::Rc}; use std::{cell::RefCell, fs::File, mem, os::unix::io::AsRawFd, rc::Rc};
use tempfile::tempdir; use tempfile::tempdir;

@ -6,12 +6,12 @@ publish = false
[dependencies] [dependencies]
anyhow = "1" anyhow = "1"
assert_matches = "1.5.0"
aya = { path = "../../aya" } aya = { path = "../../aya" }
aya-log = { path = "../../aya-log" } aya-log = { path = "../../aya-log" }
aya-obj = { path = "../../aya-obj" } aya-obj = { path = "../../aya-obj" }
libc = { version = "0.2.105" } libc = { version = "0.2.105" }
log = "0.4" log = "0.4"
matches = "0.1.8"
object = { version = "0.31", default-features = false, features = [ object = { version = "0.31", default-features = false, features = [
"elf", "elf",
"read_core", "read_core",

@ -8,7 +8,7 @@ fn run_with_rbpf() {
let object = Object::parse(crate::PASS).unwrap(); let object = Object::parse(crate::PASS).unwrap();
assert_eq!(object.programs.len(), 1); assert_eq!(object.programs.len(), 1);
matches::assert_matches!(object.programs["pass"].section, ProgramSection::Xdp { .. }); assert_matches::assert_matches!(object.programs["pass"].section, ProgramSection::Xdp { .. });
assert_eq!(object.programs["pass"].section.name(), "pass"); assert_eq!(object.programs["pass"].section.name(), "pass");
let instructions = &object let instructions = &object
@ -35,7 +35,7 @@ fn use_map_with_rbpf() {
let mut object = Object::parse(crate::MULTIMAP_BTF).unwrap(); let mut object = Object::parse(crate::MULTIMAP_BTF).unwrap();
assert_eq!(object.programs.len(), 1); assert_eq!(object.programs.len(), 1);
matches::assert_matches!( assert_matches::assert_matches!(
object.programs["tracepoint"].section, object.programs["tracepoint"].section,
ProgramSection::TracePoint { .. } ProgramSection::TracePoint { .. }
); );

Loading…
Cancel
Save